Add pedestal transport model section to CombinedTransportModel#1330
Merged
copybara-service[bot] merged 1 commit intomainfrom Jul 25, 2025
Merged
Add pedestal transport model section to CombinedTransportModel#1330copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
theo-brown
force-pushed
the
pedestal-transport
branch
from
43b78a4 to
9653014
Compare
theo-brown
commented
Jun 25, 2025
theo-brown
force-pushed
the
pedestal-transport
branch
2 times, most recently
from
53be1e0 to
48c4311
Compare
jcitrin
reviewed
Jun 30, 2025
Collaborator
jcitrin
left a comment
jcitrin
left a comment
There was a problem hiding this comment.
In addition to the comments, please update the docs following the converged-upon patterns.
theo-brown
commented
Jun 30, 2025
theo-brown
force-pushed
the
pedestal-transport
branch
3 times, most recently
from
a2fa146 to
6636467
Compare
tamaranorman
approved these changes
Jul 21, 2025
jcitrin
approved these changes
Jul 23, 2025
Collaborator
jcitrin
left a comment
jcitrin
left a comment
There was a problem hiding this comment.
Looks good! Following the small fixes + fixing the merge conflicts, will bring it it
theo-brown
force-pushed
the
pedestal-transport
branch
2 times, most recently
from
477dce7 to
e73a1e9
Compare
theo-brown
force-pushed
the
pedestal-transport
branch
from
e73a1e9 to
7efed82
Compare
Collaborator
Author
|
I've made the changes, rebased onto main, and squashed into a single commit, let me know if there's anything more that needs doing! |
jcitrin
approved these changes
Jul 25, 2025
jcitrin
added
the
copybara:import-manual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #941